search

canonical / craft-application

The basis for *craft applications
https://canonical-craft-application.readthedocs-hosted.com/en/latest
GNU Lesser General Public License v3.0
5 stars 6 forks source link

fix: set project variables in build environment #318

Closed mr-cal closed 2 months ago

mr-cal commented 2 months ago

As part of https://github.com/canonical/snapcraft/issues/4704, I discovered that CRAFT_PROJECT_NAME and CRAFT_PROJECT_VERSION were not being set in the build environment.

I'm not happy with this implementation and I want to get feedback from @tigarmo and @lengau before I spend any more time since this effort is already out of the scope of the original ticket.

(CRAFT-2657)

mr-cal commented 2 months ago

Github auto-closed this PR when the hotfix branch was deleted and I can't re-open it. I created an issue instead: #320