canonical / craft-application

The basis for *craft applications
https://canonical-craft-application.readthedocs-hosted.com/en/latest
GNU Lesser General Public License v3.0
5 stars 6 forks source link

Prefer `--use-lxd` over `CRAFT_BUILD_ENVIRONMENT` #354

Open mr-cal opened 4 weeks ago

mr-cal commented 4 weeks ago

What needs to get done

This function needs to check if --use-lxd was provided.

Why it needs to get done

The following commands will run locally, rather than in a container:

CRAFT_BUILD_ENVIRONMENT=host testcraft pack --use-lxd
# for core24 snaps
SNAPCRAFT_BUILD_ENVIRONMENT=host snapcraft pack --use-lxd

This is wrong because command line arguments should take priority over environment variables

syncronize-issues-to-jira[bot] commented 4 weeks ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-2982.

This message was autogenerated