Support `--shell` and `--shell-after` for the `pack` command - Githubissues

canonical / craft-application

The basis for *craft applications

https://canonical-craft-application.readthedocs-hosted.com/en/latest

GNU Lesser General Public License v3.0

7 stars 12 forks source link

Support `--shell` and `--shell-after` for the `pack` command #419

Closed mr-cal closed 1 month ago

mr-cal commented 2 months ago

What needs to get done

Add support for --shell and --shell-after for the pack command

Drop this override: https://github.com/canonical/craft-application/blob/a00bf9b64ab8255644b40d4013d3e75b02419872/craft_application/commands/lifecycle.py#L389
Wrap the pack steps with the shell and shell-after functions (similar to https://github.com/canonical/craft-application/issues/415)

Why it needs to get done

To allow developers to debug packing an artefact, such as https://github.com/canonical/snapcraft/issues/4963

syncronize-issues-to-jira[bot] commented 2 months ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3228.

This message was autogenerated

mr-cal commented 1 month ago

Fixed via https://github.com/canonical/craft-application/pull/436

Duplicate of https://github.com/canonical/craft-application/issues/430