search

canonical / craft-application

The basis for *craft applications
https://canonical-craft-application.readthedocs-hosted.com/en/latest
GNU Lesser General Public License v3.0
7 stars 11 forks source link

Replace proxy environment variables if fetch service is enabled #492

Closed lengau closed 2 hours ago

lengau commented 4 hours ago

What needs to get done

If a run is using the fetch service, the ProviderService should replace proxy environment variables with going to fetch service instead: https://github.com/canonical/craft-application/blob/c971a6098d5c3b93787bca217090af885088e626/craft_application/services/provider.py#L96-L98

Why it needs to get done

Prevent proxy environment variables from bypassing the fetch service or breaking things.

syncronize-issues-to-jira[bot] commented 4 hours ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3460.

This message was autogenerated

lengau commented 2 hours ago

Never mind, I missed here this is already done.