canonical / craft-application

The basis for *craft applications
https://canonical-craft-application.readthedocs-hosted.com/en/latest
GNU Lesser General Public License v3.0
7 stars 12 forks source link

Use a craft-providers callback hook to set the apt proxy by an app config #493

Open lengau opened 1 month ago

lengau commented 1 month ago

What needs to get done

In the provider service, when creating an instance, send a callback to craft-providers (see: https://github.com/canonical/craft-providers/issues/665).

The default implementation of this callback should use the config service to get the app's apt_proxy configuration and use it to configure the proxy in apt. This is roughly what's done in https://github.com/canonical/craft-application/blob/c971a6098d5c3b93787bca217090af885088e626/craft_application/fetch.py#L388-L405

When doing this, have the fetch service use this.

Why it needs to get done

Allow apt proxies in craft apps

syncronize-issues-to-jira[bot] commented 1 month ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3462.

This message was autogenerated