canonical / craft-archives

A library for handling archives/repositories in Craft applications
https://canonical-craft-archives.readthedocs-hosted.com
GNU Lesser General Public License v3.0
0 stars 8 forks source link

lint: fix lint issues with newer ruff #33

Closed lengau closed 1 year ago

lengau commented 1 year ago

A ruff update that added some more checks and a PR being merged around the same time left us with linting issues.

codecov[bot] commented 1 year ago

Codecov Report

Merging #33 (949ae2f) into main (32fc17f) will not change coverage. The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   78.42%   78.42%           
=======================================
  Files          11       11           
  Lines         496      496           
  Branches      110      110           
=======================================
  Hits          389      389           
  Misses         76       76           
  Partials       31       31           
Impacted Files Coverage Δ
craft_archives/repo/apt_key_manager.py 95.18% <ø> (ø)
craft_archives/utils.py 37.77% <0.00%> (ø)
craft_archives/repo/package_repository.py 78.43% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

syu-w commented 1 year ago

I think we need a few simple tests for this?

lengau commented 1 year ago

Yeah unit tests here are probably worth adding, but out of scope for this PR. I've made CRAFT-1641 for it.

@sergiusens can you override the codecov failure and merge?