canonical / craft-archives

A library for handling archives/repositories in Craft applications
https://canonical-craft-archives.readthedocs-hosted.com
GNU Lesser General Public License v3.0
0 stars 8 forks source link

repo: don't use gpg --show-keys #46

Closed tigarmo closed 1 year ago

tigarmo commented 1 year ago

The "--show-keys" command is only available in ubuntu 20.04 and newer; this means we need an alternative for ubuntu 18.04, which we need to support because of our tools (specifically Snapcraft)

Also update CI to run on ubuntu 18.04 instead of 20.04, to ensure our gpg calls work in the oldest version (through the integration tests).

codecov[bot] commented 1 year ago

Codecov Report

Merging #46 (912454f) into main (8b11968) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 912454f differs from pull request most recent head 8f4830c. Consider uploading reports for the commit 8f4830c to get more accurate results

@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage   82.32%   82.32%           
=======================================
  Files          12       12           
  Lines         679      679           
  Branches      154      154           
=======================================
  Hits          559      559           
  Misses         88       88           
  Partials       32       32           
Impacted Files Coverage Δ
craft_archives/repo/apt_key_manager.py 98.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.