canonical / craft-archives

A library for handling archives/repositories in Craft applications
https://canonical-craft-archives.readthedocs-hosted.com
GNU Lesser General Public License v3.0
0 stars 7 forks source link

repo: fix bad typing_extensions interaction #78

Closed tigarmo closed 1 year ago

tigarmo commented 1 year ago

Ref: https://github.com/pydantic/pydantic/issues/5821#issuecomment-1559196859 We could also pin typing_extensions to 4.5.0 instead, but those pins have a tendency of sticking around.


codecov[bot] commented 1 year ago

Codecov Report

Merging #78 (fcaf90f) into main (fd9fac8) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   88.09%   88.11%   +0.01%     
==========================================
  Files          13       13              
  Lines         630      631       +1     
  Branches      125      125              
==========================================
+ Hits          555      556       +1     
  Misses         61       61              
  Partials       14       14              
Impacted Files Coverage Δ
craft_archives/repo/package_repository.py 98.76% <100.00%> (+<0.01%) :arrow_up:
tigarmo commented 1 year ago

@lengau sure, done! Might have gone overboard with the comment maybe heh