canonical / craft-cli

https://canonical-craft-cli.readthedocs-hosted.com/en/latest/
GNU Lesser General Public License v3.0
9 stars 15 forks source link

tools: enable ruff #173

Closed tigarmo closed 1 year ago

tigarmo commented 1 year ago

This PR enables ruff and removes pylint. In the process of fixing ruff errors, mypy and pyright issues are also addressed.

The commits are split to facilitate review:

After the review is done I'll clean the commits up and keep only a handful with better messages.

Fixes #146

codecov[bot] commented 1 year ago

Codecov Report

Merging #173 (a13c3b1) into main (8b81d8e) will increase coverage by 0.08%. The diff coverage is 97.76%.

@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
+ Coverage   94.54%   94.62%   +0.08%     
==========================================
  Files           7        7              
  Lines        1044     1042       -2     
  Branches      192      190       -2     
==========================================
- Hits          987      986       -1     
  Misses         53       53              
+ Partials        4        3       -1     
Files Changed Coverage Δ
craft_cli/pytest_plugin.py 46.87% <57.14%> (+0.63%) :arrow_up:
craft_cli/__init__.py 100.00% <100.00%> (ø)
craft_cli/dispatcher.py 99.13% <100.00%> (ø)
craft_cli/errors.py 100.00% <100.00%> (ø)
craft_cli/helptexts.py 98.01% <100.00%> (+1.19%) :arrow_up:
craft_cli/messages.py 100.00% <100.00%> (ø)
craft_cli/printer.py 100.00% <100.00%> (ø)