Closed tigarmo closed 11 months ago
Merging #177 (bcbcda8) into main (41246d1) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## main #177 +/- ##
=======================================
Coverage 94.62% 94.62%
=======================================
Files 7 7
Lines 1042 1042
Branches 190 190
=======================================
Hits 986 986
Misses 53 53
Partials 3 3
Files Changed | Coverage Δ | |
---|---|---|
craft_cli/dispatcher.py | 99.13% <100.00%> (ø) |
Commit b0698f9 changed the type annotation for the return value of BaseCommand.run() from
Optional[int]
to the semantically-equivalent preferred notationint | None
.However, this is a breaking change in the case of subclasses that override this method, return only
None
and use theoverride
decorator from non-latest versions of theoverride
package, as those versions do not realize thatNone
is a valid subset ofint | None
.Although the fix in client code is simple, the original commit was not meant to break client code at all. Therefore, revert this specific change until we are ready to release a new major version.
tox
?