canonical / craft-cli

https://canonical-craft-cli.readthedocs-hosted.com/en/latest/
GNU Lesser General Public License v3.0
9 stars 15 forks source link

fix: clear prefix for message() and error() #203

Closed tigarmo closed 9 months ago

tigarmo commented 9 months ago

The first commit fixes a bug I bumped into where an emit.progress() followed by an emit.message() would send the carriage return (to clear the ephemeral progress) to the wrong stream. The second commit then does the actual clearing of the prefix.

Fixes #202

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bbff5f5) 93.13% compared to head (917fa5f) 94.76%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #203 +/- ## ========================================== + Coverage 93.13% 94.76% +1.63% ========================================== Files 7 7 Lines 1063 1070 +7 Branches 194 197 +3 ========================================== + Hits 990 1014 +24 + Misses 66 53 -13 + Partials 7 3 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.