fix: remove trailing spaces where supported

lengau commented 10 months ago

Fixes #136 CRAFT-3358

[x] Have you followed the guidelines for contributing?
[x] Have you signed the CLA?
[x] Have you successfully run tox?

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.83%. Comparing base (99394c9) to head (fd38bb7). Report is 6 commits behind head on main.

:exclamation: Current head fd38bb7 differs from pull request most recent head 3f19cb1. Consider uploading reports for the commit 3f19cb1 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #210 +/- ## ========================================== + Coverage 93.24% 94.83% +1.59% ========================================== Files 7 7 Lines 1080 1084 +4 Branches 200 200 ========================================== + Hits 1007 1028 +21 + Misses 66 53 -13 + Partials 7 3 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tigarmo commented 1 month ago

@lengau I played around with this a bit and it seems to be working fine! That is, no breakage that I could see One thing that I'd like your opinion on though is the new behavior where the cursor keeps jumping around the row as the line that's printed is shorter or longer; I found that distracting but maybe I'm too close to the issue to get a good sense.

lengau commented 3 weeks ago

@tigarmo based on our team discussions I've created https://github.com/canonical/craft-cli/pull/275 to go along with this and cover the cursor hiding.

canonical / craft-cli

fix: remove trailing spaces where supported #210

Codecov Report