search

canonical / data-platform-libs

A collection of charm libraries curated by the Data Platform Team
https://charmhub.io/data-platform-libs
Apache License 2.0
9 stars 9 forks source link

[DPE-2850][FIX] Secret content duplication AND rolling update safe #107

Closed juditnovak closed 9 months ago

juditnovak commented 9 months ago

A major bug was discovered. When using secrets, all secret info was also duplicated into the databag.

Details:

On line 783 the second_chance_as_normal_field variable was always true. (Should have been set False in modification functions, by mistake.)

However since in parallel we had concerns regarding rolling upgrades, I provided a fix that also addresses the rolling upgrades issue.

During development another bug was discovered. To be fixed in a separate PR. Tests xfail-ing until.

juditnovak commented 9 months ago

TODO: Increase LIBPATCH!!!