search

canonical / data-platform-libs

A collection of charm libraries curated by the Data Platform Team
https://charmhub.io/data-platform-libs
Apache License 2.0
9 stars 7 forks source link

Update data-platform-workflows used in this repository to avoid Node16 warnings #178

Open shayancanonical opened 2 weeks ago

shayancanonical commented 2 weeks ago

Steps to reproduce

The following test run has a bunch of warnings for deprecation of Node 16 due to usage of actions/checkout@v3 which originates from data-platform-workflows@v2

Expected behavior

No warnings

Actual behavior

A lot of warnings because we are using a very old version of data-platform-workflows

Versions

n/a

Log output

n/a

Additional context

n/a

github-actions[bot] commented 2 weeks ago

https://warthogs.atlassian.net/browse/DPE-4689

carlcsaposs-canonical commented 2 weeks ago

per request from @shayancanonical, migration instructions (may be other details I missed, went through this quickly) here are all the breaking changes that are relevant from v2 to the latest version: https://github.com/canonical/data-platform-workflows/releases/tag/v3.0.0 https://github.com/canonical/data-platform-workflows/releases/tag/v5.0.0 https://github.com/canonical/data-platform-workflows/releases/tag/v9.0.0 https://github.com/canonical/data-platform-workflows/releases/tag/v10.0.0

from a quick glance, follow migration instructions in v10, add charm to charmcraftcache (check that you're using supported build wrapper or no build wrapper), and cleanup old integration test code that looks at CI_PACKED_CHARMS

migration instructions to v9: https://chat.canonical.com/canonical/pl/83744yqxut8mxk4dsxb9q3nfie