Closed marcoppenheimer closed 1 year ago
LGTM, charmcraft is not happy a bit:
2023-07-01 17:32:12.936 :: 2023-07-01 17:32:12.087 :: :: error: can't find Rust compiler .... 2023-07-01 17:32:12.936 :: 2023-07-01 17:32:12.087 :: :: ERROR: Failed building wheel for maturin
Q: are we moving to ruff for entire team?
I think we should! It's much faster than flake, fewer imports.
I think we should! It's much faster than flake, fewer imports.
I agree (unless ruff conflicts with other tools with no clean solution for it) but given we don't have any standard set up yet, I would leave it up to the products/team/projects to decide whether to use it or not for the time being.
Changes Made
style: add pyright type checks, ruff linting
tox -e lint
src
andlib
flake8
Pylance
) is the default type checker that ships with thems-python.python
VSCode extension, and is very good