refactor: unify k8s+vm upgrade pattern - Githubissues

canonical / data-platform-libs

A collection of charm libraries curated by the Data Platform Team

https://charmhub.io/data-platform-libs

Apache License 2.0

9 stars 9 forks source link

refactor: unify k8s+vm upgrade pattern #83

Closed marcoppenheimer closed 6 months ago

marcoppenheimer commented 12 months ago

TODO

Test on live charm when K8s examples exist
Add + update tests
Add + update full usage docstring

Changes Made

`refactor: remove upgrade-finished event + handler, use relation-changed`

Moving the logic to relation-changed to be coordinated by the Juju leader
NOTE - Does mean that charms need to recurse on leader. Possibly not as have added a call on set_unit_completed. Needs testing

`feat: add resume-strategy to pre-upgrade-check`

auto - all units upgrade automatically
- Default on VM
safe - upgrade pauses on first unit
- Default on K8s

`refactor: add unified _update_stack()`

Leader-only
On K8s, shifts partition
Updates relation-data stack
Called during resume-upgrade action, and if completed top of stack + first unit + 'safe'

marcoppenheimer commented 6 months ago

Closing as no longer relevant.