search

canonical / data-platform-workflows

Reusable GitHub Actions workflows used by the Data Platform team
Apache License 2.0
4 stars 9 forks source link

breaking(release_charm.yaml): Upload OCI resources from GHCR directly #198

Closed carlcsaposs-canonical closed 3 months ago

carlcsaposs-canonical commented 3 months ago

charmcraft 2.7.0 contains a fix for multi-arch OCI images issue: https://github.com/canonical/charmcraft/issues/1685 fix: https://github.com/canonical/charmcraft/pull/1708

However, it fixes it in a "backwards-compatible" way—if the image is available locally, it will still upload it incorrectly.

Stop downloading the image locally & always use GHCR so that charmcraft uploads the image correctly

This will break on charmcraft < 2.7.0

carlcsaposs-canonical commented 3 months ago

charmcraft 2.7.0 is currently in 2.x/candidate released to stable

carlcsaposs-canonical commented 3 months ago

tested on https://github.com/canonical/postgresql-k8s-operator/pull/490

carlcsaposs-canonical commented 3 months ago

tested on single-arch charm: https://github.com/canonical/mysql-k8s-operator/pull/437