search

canonical / data-science-stack

Stack with machine learning tools needed for local development.
Apache License 2.0
18 stars 7 forks source link

Remove repeated output while waiting for deployment #170

Closed misohu closed 2 months ago

misohu commented 2 months ago

Closes: https://github.com/canonical/data-science-stack/issues/159

Because there is shared function for waiting for any deployment to be ready we only had to change code in one place :)

Manual test:

git clone <repo>
cd <repo>
pip install .
dss initialize --kubeconfig="$(sudo microk8s config)"
dss create my-notebook --image=pytorch

The message Waiting for deployment <deployment-name> in namespace dss to be ready... should appear only once in both cases.

misohu commented 2 months ago

Thanks @rgildein that was a good idea ... I have swapped it for debug ... debug does not go to console so its perfect.