canonical / deployment-configs

10 stars 12 forks source link

Allow passing of database URL #393

Closed jpmartinspt closed 4 years ago

jpmartinspt commented 4 years ago

Done

Allow passing database URL so we can override the connection string in case we want to connect to a development database.

QA

jkfran commented 4 years ago

In the snapcraft.yaml change this:

command: konf.py

to

command: bin/konf.py
jpmartinspt commented 4 years ago

@nottrobin @jkfran @tbille @albertkol @carkod when you make changes to this repo you can now download the built snap as an artifact for each workflow that is run, as explained here. You can then manually install the snap to QA.

jpmartinspt commented 4 years ago

@nottrobin removed the walrus.

jkfran commented 4 years ago

@jpmartinspt Sorry, I approved the changes but after tanking a deep look in the case of ubuntu.com, we have 2 routes (ubuntu-com-blog and ubuntu-com-tutorials) using the database secret as well and the secret value is not being replaced by this change.

jpmartinspt commented 4 years ago

@jkfran No worries, I think we got routes covered now as well!