canonical / design-vanilla-framework

Design components for Vanilla Framework.
https://vanillaframework.io
GNU General Public License v3.0
62 stars 11 forks source link

The active state of the navigation header is too sublte #449

Closed clagom closed 4 years ago

clagom commented 4 years ago

During our meetings with Mark, he mentioned that on Vanilla level he doesn't think the current active state of the navigation header is clear enough. He did mockup this as an example, with the active link on a white background, similar to a tab: Screenshot 2020-06-23 at 09.41.35.png

We might implement this on CharmHub.io first.

Link: https://docs.google.com/document/d/1JzRjODk3UkZ-y2cg1SdG_RuOqMF0SkqN5uqyIa4G4Ig/edit

lyubomir-popov commented 4 years ago

@spencerbygraves @clagom @cassiocassio Some thoughts and a proposal ( in case there's room to negotiate :) )

https://miro.com/app/board/o9J_kqPIMZQ=/

clagom commented 4 years ago

Looks good to me, worth going back and propose it. Do we roughly know when this could happen?

spencerbygraves commented 4 years ago

@clagom we looked at this in the design review this morning. We discussed adding the white tab to Charm Hub for Montreal as per Mark's request, and having this in a separate branch to also show as a proposal.

lyubomir-popov commented 4 years ago

@clagom I can be ready with the proposal next week. Then maybe we can setup demos of vanillaframework.io, maas.io, snapcraft.io and charmhub to illustrate it better. It's a couple of lines of css so making a few demo prs is trivial.

clagom commented 4 years ago

Sounds good. The next Charm Hub meeting will be in the Virtual Montreal, maybe we can setup a session with you then. If not, the proposal can be presented in the next bi-weekly meeting.

solazio commented 4 years ago

Please consider medium to large screen sizes where the navigation buttons are wrapped on 2 rows image

lyubomir-popov commented 4 years ago

@solazio By this point the nav should have switched to a mobile responsive version, truncating the less important part of the account email (should it use the provided email to begin with? Why not an alias or user name?).

But in case that happens unintendedly - and it has happened before - you're right it should look better. The proposal I'm working on would handle it like this:

Horisontal-nav-graceful-degradation

solazio commented 4 years ago

@lyubomir-popov yes, the email will be replaced by an alias or name. In your case the highlighted part works fine, but in my case (full white) it looks very disconnected from the page.

lyubomir-popov commented 4 years ago

@solazio I'll make sure we highlight this when we explain why we are proposing an alternative to the full white highlight.

lyubomir-popov commented 4 years ago

I've made a case for an alternative treatment of the active page highlight here: https://zpl.io/bAoJGKp

Please take a look and comment.