Pictos: Update page copy

canonical / design.ubuntu.com

7 stars 29 forks source link

Pictos: Update page copy #73

Closed deadlight closed 7 years ago

deadlight commented 7 years ago

Done

Made pictogram copy match the live site

QA

./run
Navigate to the pictogram page
Compare with live

Issue / Card

Fixes #62

webteam-app commented 7 years ago

Starting demo at: http://design.ubuntu.com-pr-73.run.demo.haus/

barrymcgee commented 7 years ago

The grid is broken on that page, check the "Back to top" links

deadlight commented 7 years ago

@barrymcgee apologies, the scope of this review is the content, I should have been clearer. The current master has the same odd use of the build.

The placement of the navigation menu will be addressed in the upcoming vanilla upgrade and navigation rebuild.

deadlight commented 7 years ago

@barrymcgee oh, wait... I see what you mean. Will fix.

deadlight commented 7 years ago

@barrymcgee ready for re-review

barrymcgee commented 7 years ago

@deadlight Still seeing grid weirdness where nesting strips and rows means that the content area is not filling the full col-8 available to it which means it's not lining up with the footer.

deadlight commented 7 years ago

@barrymcgee I found the problem with nested col-*, I'll create an issue to fix other instances across the site but I've fixed this one for now.