search

canonical / dex-auth-operator

Operator for Dex Auth
Apache License 2.0
3 stars 14 forks source link

Add a default `public-url` config value #123

Closed ca-scribner closed 2 months ago

ca-scribner commented 1 year ago

This adds a default public-url config value as described in canonical/bundle-kubeflow#608. After implementing canonical/bundle-kubeflow#608 as a whole, we remove the need for users to modify public-url.

While we could deprecate and remove the public-url config, it is recommended we leave it as is with this default. This is because in the medium term we plan on replacing dex+oidc with a different auth setup.

i-chvets commented 1 year ago

LGTM, but need to fix CI.

DnPlas commented 2 months ago

Thanks @ca-scribner for the proposal. In the end this change will be slightly different. Please see https://github.com/canonical/dex-auth-operator/pull/211 for more information.