canonical / dex-auth-operator

Operator for Dex Auth
Apache License 2.0
3 stars 14 forks source link

dex-auth-operator fails tests track/2.31 #136

Closed i-chvets closed 1 year ago

i-chvets commented 1 year ago

Description

Discovered during running on pull request workflows when not related image retrieval script was checked in. Integration tests are not starting after many attempts.Fails on setup:

 /usr/bin/sg microk8s -c juju bootstrap --debug --verbose microk8s github-pr-08a8c --model-default test-mode=true --model-default automatically-retry-hooks=false --model-default logging-config="<root>=DEBUG" --agent-version=2.9.34 --bootstrap-constraints=""
  ERROR cannot load ssh client keys: mkdir /home/runner/.local: permission denied
  Error: The process '/usr/bin/sg' failed with exit code 2

This PR has the logs/traces for failing tests https://github.com/canonical/dex-auth-operator/pull/135

Two problems were observed:

Need to review and address failing tests.

Solution

Solutions were proposed in https://github.com/canonical/bundle-kubeflow/issues/648 SDI schema update solved the issue with integration tests. https://github.com/canonical/serialized-data-interface/pull/51 https://github.com/canonical/serialized-data-interface/pull/51

i-chvets commented 1 year ago

Invalid solution:

~~In order for Dex inb track/2.31 to pass CI, requirements must be updated. Updating requirements requires to bump SDI. This in turn requires code change to dex in track/2.31. This is the commit that has needed change. Code change required:~~

i-chvets commented 1 year ago

After debugging session it was concluded that solutions proposed in https://github.com/canonical/bundle-kubeflow/issues/648 cannot be used in Dex's case. New possible approach is summarized in the same issue to keep information in one place.

i-chvets commented 1 year ago

PR is ready for review https://github.com/canonical/dex-auth-operator/pull/143

i-chvets commented 1 year ago

Fix is merged. Closing.