search

canonical / dex-auth-operator

Operator for Dex Auth
Apache License 2.0
3 stars 14 forks source link

chore: keep public-url config option for compatibility #213

Closed DnPlas closed 1 month ago

DnPlas commented 1 month ago

Since this is a breaking change, it is preferrable to keep some sort of compatibility that allow users with existing deployments to keep running Dex even after the upgrade. This configuration option can be removed after a deprecation notice is rolled out.

Testing instructions

  1. Deploy dex-auth from 2.36/stable
  2. Configure public-url with any value `juju config dex-auth public-url="my-known-value.io"
  3. Verify this value is populated in Dex's OIDC configuration:
curl -v <dex's svc>:5556/dex/.well-known/openid-configuration
{
  "issuer": "my-known-value.io/dex",
...
  1. Refresh dex-auth to the charm from this PR
  2. Without changing the charm configuration, make sure that Dex's OIDC configuration persists
curl -v <dex's svc>:5556/dex/.well-known/openid-configuration
{
  "issuer": "my-known-value.io/dex",
...
  1. As an extra check, make sure the deprecation notice is logged juju debug-log