search

canonical / discourse-gatekeeper

Experimental GitHub Action to upload charm documentation to charmhub
Apache License 2.0
7 stars 7 forks source link

Update git package to git-svn 1:2.39.2-1.1 #177

Closed arturo-seijas closed 1 year ago

arturo-seijas commented 1 year ago

The image build is currently failing because the git package is not available anymore

TeodorPt commented 1 year ago

This problem would resurface whenever python:3.11-slim is updated again to a new series. Why is the git version pinned? If needed, should the python image also be pinned (e.g. python:3.11-slim-bookworm)?

arturo-seijas commented 1 year ago

python:3.11-slim-bookworm

Indeed, we should probably pin the image too

github-actions[bot] commented 1 year ago

Test coverage for 5020553e57c7fca460459354e9bab5d63705cb6f

Name                      Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------------
src/__init__.py              60      0     20      0   100%
src/action.py               156      0     46      0   100%
src/check.py                 29      0     10      0   100%
src/clients.py               12      0      0      0   100%
src/constants.py              6      0      0      0   100%
src/content.py               52      0      8      0   100%
src/discourse.py            156      0     34      0   100%
src/docs_directory.py        33      0      8      0   100%
src/download.py              23      0      2      0   100%
src/exceptions.py            14      0      0      0   100%
src/index.py                 28      0      6      0   100%
src/metadata.py              28      0     12      0   100%
src/migration.py             87      0     27      0   100%
src/navigation_table.py      63      0     20      0   100%
src/reconcile.py             85      0     40      0   100%
src/repository.py           238      0     76      0   100%
src/types_.py               125      0     22      0   100%
---------------------------------------------------------------------
TOTAL                      1195      0    331      0   100%

Static code analysis report

Run started:2023-06-15 11:04:12.806393

Test results:
    No issues identified.

Code scanned:
    Total lines of code: 10690
    Total lines skipped (#nosec): 14
    Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
    Total issues (by severity):
        Undefined: 0
        Low: 0
        Medium: 0
        High: 0
    Total issues (by confidence):
        Undefined: 0
        Low: 0
        Medium: 0
        High: 0
Files skipped (0):
jdkandersson commented 1 year ago

actually git is available, it just needs to have a higher version