canonical / discourse-gatekeeper

Experimental GitHub Action to upload charm documentation to charmhub
Apache License 2.0
7 stars 7 forks source link

change logic to not consider update actions where local and server is the same #179

Closed jdkandersson closed 1 year ago

jdkandersson commented 1 year ago

Changes the conflict detection logic to ignore update actions where the local (on the PR) and server (on discourse) content is the same for the purpose of logical conflict detection

github-actions[bot] commented 1 year ago

Test coverage for fde4e335853b17000f59b8d68ea6be7409e3e99d

Name                      Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------------
src/__init__.py              60      0     20      0   100%
src/action.py               154      0     46      0   100%
src/check.py                 53      0     21      0   100%
src/clients.py               12      0      0      0   100%
src/constants.py              7      0      0      0   100%
src/content.py               50      0     10      0   100%
src/discourse.py            156      0     34      0   100%
src/docs_directory.py        33      0      8      0   100%
src/download.py              23      0      2      0   100%
src/exceptions.py            14      0      0      0   100%
src/index.py                 28      0      6      0   100%
src/metadata.py              28      0     12      0   100%
src/migration.py             87      0     27      0   100%
src/navigation_table.py      63      0     20      0   100%
src/reconcile.py             85      0     40      0   100%
src/repository.py           238      0     76      0   100%
src/types_.py               125      0     22      0   100%
---------------------------------------------------------------------
TOTAL                      1216      0    344      0   100%

Static code analysis report

Run started:2023-06-20 07:55:51.833134

Test results:
    No issues identified.

Code scanned:
    Total lines of code: 11038
    Total lines skipped (#nosec): 14
    Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
    Total issues (by severity):
        Undefined: 0
        Low: 0
        Medium: 0
        High: 0
    Total issues (by confidence):
        Undefined: 0
        Low: 0
        Medium: 0
        High: 0
Files skipped (0):
deusebio commented 1 year ago

Makes sense! LGTM