canonical / discourse-gatekeeper

Experimental GitHub Action to upload charm documentation to charmhub
Apache License 2.0
7 stars 7 forks source link

[MISC] Fixing bug arising when repositories are shallow #209

Closed deusebio closed 10 months ago

deusebio commented 10 months ago

The actions are most-likely failing across repositories, since we have introduced a check to make sure that tags do indeed belong to the base branch.

However, git repositories in Github Actions are shallow, only carrying a single commit. Therefore, the checks may erroneously fail since the documentation tag commit is unknown to the base branch.

While doing this I have also slightly refactored the pre_flight_check to provide some more meaningful logging

github-actions[bot] commented 10 months ago

Test coverage for 6da32f10dde12984d84d1dfa8dd2dce208d0d41c

Name                      Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------------
src/__init__.py              83      0     34      0   100%
src/action.py               154      0     46      0   100%
src/check.py                 53      0     21      0   100%
src/clients.py               12      0      0      0   100%
src/commit.py                42      0     12      0   100%
src/constants.py              9      0      0      0   100%
src/content.py               50      0     10      0   100%
src/discourse.py            156      0     34      0   100%
src/docs_directory.py        33      0      8      0   100%
src/download.py              23      0      2      0   100%
src/exceptions.py            15      0      0      0   100%
src/index.py                128      0     48      0   100%
src/metadata.py              28      0     12      0   100%
src/migration.py             87      0     27      0   100%
src/navigation_table.py      65      0     20      0   100%
src/reconcile.py             95      0     44      0   100%
src/repository.py           283      0     88      0   100%
src/sort.py                  39      0     22      0   100%
src/types_.py               147      0     22      0   100%
---------------------------------------------------------------------
TOTAL                      1502      0    450      0   100%

Static code analysis report

Working... ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:02
Run started:2023-09-06 14:50:55.539378

Test results:
    No issues identified.

Code scanned:
    Total lines of code: 15681
    Total lines skipped (#nosec): 14
    Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
    Total issues (by severity):
        Undefined: 0
        Low: 0
        Medium: 0
        High: 0
    Total issues (by confidence):
        Undefined: 0
        Low: 0
        Medium: 0
        High: 0
Files skipped (0):