canonical / discourse-gatekeeper

Experimental GitHub Action to upload charm documentation to charmhub
Apache License 2.0
7 stars 7 forks source link

Fix nothing to migrate bug #231

Closed jdkandersson closed 6 months ago

jdkandersson commented 6 months ago

Applicable spec: N/A

Overview

There was an issue where the action attempts to perform migration when the default branch and discourse match but the base content tag is behind. This now no longer attempts to perform migration and also moves the tag to the latest commit on the default branch.

Rationale

To resolve a bug as described above.

Module Changes

The migration module no longer attempts to migrate when the default branch and discourse are up to date.

Checklist

github-actions[bot] commented 6 months ago

Test coverage for 1f1b225fb40a37ec65317c8849ebe7d9689a42c5

Name                      Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------------
src/__init__.py              97      0     42      0   100%
src/action.py               155      0     46      0   100%
src/check.py                 67      0     27      0   100%
src/clients.py               12      0      0      0   100%
src/commit.py                42      0     12      0   100%
src/constants.py             10      0      0      0   100%
src/content.py               50      0     10      0   100%
src/discourse.py            159      0     34      0   100%
src/docs_directory.py        33      0      8      0   100%
src/download.py              23      0      2      0   100%
src/exceptions.py            15      0      0      0   100%
src/index.py                142      0     56      0   100%
src/metadata.py              28      0     12      0   100%
src/migration.py            102      0     33      0   100%
src/navigation_table.py      65      0     20      0   100%
src/reconcile.py            123      0     60      0   100%
src/repository.py           284      0     88      0   100%
src/sort.py                  43      0     26      0   100%
src/types_.py               199      0     54      0   100%
---------------------------------------------------------------------
TOTAL                      1649      0    530      0   100%

Static code analysis report

Working... ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:01
Run started:2024-01-19 04:41:01.102883

Test results:
    No issues identified.

Code scanned:
    Total lines of code: 17611
    Total lines skipped (#nosec): 3
    Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
    Total issues (by severity):
        Undefined: 0
        Low: 0
        Medium: 0
        High: 0
    Total issues (by confidence):
        Undefined: 0
        Low: 0
        Medium: 0
        High: 0
Files skipped (0):