canonical / discourse-gatekeeper

Experimental GitHub Action to upload charm documentation to charmhub
Apache License 2.0
7 stars 7 forks source link

Removed `discourse-gatekeeper/discourse-ahead-ok` #235

Closed codethulu closed 5 months ago

codethulu commented 5 months ago

Applicable spec: N/A

Overview

Removed discourse-gatekeeper/discourse-ahead-ok and related documentation, as this is no longer required.

Rationale

Using discourse-gatekeeper/discourse-ahead-ok should no longer be possible.

Module Changes

N/A

Checklist

codethulu commented 5 months ago

ERROR root:check.py:205 there is a problem preventing the execution of an action path: doc problem: detected unmerged community contributions, these need to be resolved before proceeding. Paths with potentially unmerged community contributions: {'doc', 'alt-doc'}.

Getting this error at the moment which seems to be failing the integration test. Besides this, I believe that I have made the necessary changes. All unit tests are passing as expected.

codethulu commented 5 months ago

Tests just finished wrapping up. I believe that all necessary changes have been made, and this is ready for review.

Thanhphan1147 commented 5 months ago

Hi, is the deletion of files in src-docs intended?

codethulu commented 5 months ago

Hmmm seems as though src-docs did not generate. I think this may be attributed due to some strange python path behaviour. I'll try fix it up and generate the src-docs now..

codethulu commented 5 months ago

Addressed conversation about comments in test file 👍

github-actions[bot] commented 5 months ago

Test coverage for 3826b69db0b79a4b0146670914b12bdee40b4475

Name                      Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------------
src/__init__.py              97      0     42      0   100%
src/action.py               155      0     46      0   100%
src/check.py                 63      0     25      0   100%
src/clients.py               12      0      0      0   100%
src/commit.py                42      0     12      0   100%
src/constants.py              9      0      0      0   100%
src/content.py               50      0     10      0   100%
src/discourse.py            159      0     34      0   100%
src/docs_directory.py        33      0      8      0   100%
src/download.py              23      0      2      0   100%
src/exceptions.py            15      0      0      0   100%
src/index.py                142      0     56      0   100%
src/metadata.py              28      0     12      0   100%
src/migration.py            102      0     33      0   100%
src/navigation_table.py      65      0     20      0   100%
src/reconcile.py            123      0     60      0   100%
src/repository.py           284      0     88      0   100%
src/sort.py                  43      0     26      0   100%
src/types_.py               201      0     54      0   100%
---------------------------------------------------------------------
TOTAL                      1646      0    528      0   100%

Static code analysis report

Working... ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:02
Run started:2024-02-16 15:35:08.240822

Test results:
    No issues identified.

Code scanned:
    Total lines of code: 17537
    Total lines skipped (#nosec): 3
    Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
    Total issues (by severity):
        Undefined: 0
        Low: 0
        Medium: 0
        High: 0
    Total issues (by confidence):
        Undefined: 0
        Low: 0
        Medium: 0
        High: 0
Files skipped (0):