canonical / discourse-k8s-operator

discourse-k8s-operator - charm repository.
Apache License 2.0
6 stars 5 forks source link

ISD-1838 run command to enable plugin one at a time. #231

Closed Thanhphan1147 closed 3 months ago

Thanhphan1147 commented 4 months ago

Overview

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

github-actions[bot] commented 4 months ago

Lint checks failed for 6d2004586644cb329b3f6342bfc3ce7bd8440f42

```

/home/ubuntu/github-runner/_work/discourse-k8s-operator/discourse-k8s-operator/src/charm.py:784 in private method _on_enable_plugins_action: D205: 1 blank line required between summary line and description (found 0)

github-actions[bot] commented 4 months ago

Test coverage for 6d2004586644cb329b3f6342bfc3ce7bd8440f42

Name              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------
src/charm.py        338     42     84     12    86%   186, 194-195, 207, 335->343, 376->381, 393, 581-583, 588-589, 601-603, 608-609, 621-623, 646-648, 690->exit, 700->exit, 730-736, 762->exit, 776-777, 788-817, 823->exit, 837
src/database.py      30      1      8      1    95%   56
-------------------------------------------------------------
TOTAL               368     43     92     13    87%

Static code analysis report

Run started:2024-04-30 04:12:46.780197

Test results:
    No issues identified.

Code scanned:
    Total lines of code: 2010
    Total lines skipped (#nosec): 3
    Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
    Total issues (by severity):
        Undefined: 0
        Low: 0
        Medium: 0
        High: 0
    Total issues (by confidence):
        Undefined: 0
        Low: 0
        Medium: 0
        High: 0
Files skipped (0):
javierdelapuente commented 3 months ago

I close this as I believe we are not going to merge. @Thanhphan1147