canonical / docker-snap

https://snapcraft.io/docker
MIT License
54 stars 27 forks source link

Docker snap doesn't work on ZFS #112

Closed omar-selo closed 1 year ago

omar-selo commented 1 year ago

I'm facing the same issue mentioned here. Basically, on a ZFS system docker snap just doesn't work. The workaround is to modify the storage driver specified in /var/snap/docker/current/config/daemon.json to zfs. Ideally, this configuration should be part of snap's installation. If not at least it would be nice to have this info in the readme.

zhsj commented 1 year ago

IMO, we could stop setting storage-driver in daemon.json, then docker will determinate the best one itself.

Not sure if there's any side-effect.

xnox commented 1 year ago

at install time sure, but will it be preserved on snap refreshes? I believe we want to continue to use storage-driver A on existing installs, even if storage-driver B has become the new best default.

tianon commented 1 year ago

IMO removing the setting is probably the best answer -- Docker itself will automatically choose the "best" one, preferring what already exists followed by https://github.com/moby/moby/blob/cba6f2d42698b1d15e031efa18a59843859f2200/daemon/graphdriver/driver_linux.go#L53

xnox commented 1 year ago

let's do this then.