search

canonical / docker-snap

https://snapcraft.io/docker
MIT License
52 stars 27 forks source link

Backport patches to enable support for changes to latest golang #150

Closed jocado closed 1 year ago

jocado commented 1 year ago

Without this patch, snap builds produce a snap with a non-functional docker cli and client, they fail with http: invalid Host header

REF: https://github.com/moby/moby/issues/45935

jocado commented 1 year ago

For ref, here is an example failure for an action log: https://github.com/docker-snap/docker-snap/actions/runs/5684149041/job/15406223201#step:10:6

lucaskanashiro commented 1 year ago

Thanks for this PR @jocado ! I see the patch you are proposing was already merged upstream:

https://github.com/moby/moby/commit/dab9ffb252186f4c47416addb136d579f9314c6a

This fix is present in version 24.0.5:

https://github.com/moby/moby/releases/tag/v24.0.5

I am planning to push 24.0.5 to latest/edge soon but it would take a while until we promote it to latest/stable. So I think the best route is to merge your change, follow all the process to promote it to latest/stable and then update latest/edge to 24.0.5.

The smoke test also passed against your branch, so I believe we are good to go.

lucaskanashiro commented 1 year ago

If you want to test yourself, I just uploaded it to the snap store:

Revision 2903 created for 'docker' and released to 'latest/edge'