search

canonical / dqlite

Embeddable, replicated and fault-tolerant SQL engine.
https://dqlite.io
Other
3.8k stars 215 forks source link

server: Remove assert of uv_loop_close rv. #505

Closed MathieuBordere closed 1 year ago

MathieuBordere commented 1 year ago

The assert can be reintroduced once the TODO has been fixed.

See #504

codecov[bot] commented 1 year ago

Codecov Report

Merging #505 (c0c4224) into master (c3ac4d8) will decrease coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Current head c0c4224 differs from pull request most recent head 4ca94f6. Consider uploading reports for the commit 4ca94f6 to get more accurate results

@@            Coverage Diff             @@
##           master     #505      +/-   ##
==========================================
- Coverage   60.97%   60.97%   -0.01%     
==========================================
  Files          34       34              
  Lines        6340     6339       -1     
  Branches     1884     1884              
==========================================
- Hits         3866     3865       -1     
  Misses       1293     1293              
  Partials     1181     1181
Impacted Files Coverage Δ
src/server.c 55.47% <100.00%> (-0.09%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

freeekanayaka commented 1 year ago

Thanks for the detailed explanation. Please could you also add a reference to #504 in the comment added by this PR? It has valuable info to understand the situation.