canonical / dqlite

Embeddable, replicated and fault-tolerant SQL engine.
https://dqlite.io
Other
3.8k stars 215 forks source link

Polyfill __builtin_assume_aligned for tcc #506

Closed cole-miller closed 1 year ago

cole-miller commented 1 year ago

I've been messing around with using Fabrice Bellard's tcc for local builds; this is the only change that's really required for libdqlite to build successfully (have not tried the test suite yet).

The only reason we call __builtin_assume_aligned is to silence a warning from GCC/Clang about unaligned accesses; tcc doesn't have that warning.

Signed-off-by: Cole Miller cole.miller@canonical.com

codecov[bot] commented 1 year ago

Codecov Report

Merging #506 (7f55c59) into master (c3ac4d8) will decrease coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #506      +/-   ##
==========================================
- Coverage   60.97%   60.97%   -0.01%     
==========================================
  Files          34       34              
  Lines        6340     6339       -1     
  Branches     1884     1884              
==========================================
- Hits         3866     3865       -1     
  Misses       1293     1293              
  Partials     1181     1181              
Impacted Files Coverage Δ
src/format.c 65.38% <ø> (ø)
src/vfs.c 77.26% <ø> (ø)

... and 1 file with indirect coverage changes

freeekanayaka commented 1 year ago

Nice.