canonical / dqlite

Embeddable, replicated and fault-tolerant SQL engine.
https://dqlite.io
Other
3.8k stars 214 forks source link

server: Fix overflow issue with return of lseek #519

Closed cole-miller closed 1 year ago

cole-miller commented 1 year ago

The previous code would behave incorrectly when reading an info file or node store with a size too large to be represented by ssize_t. (This is only possible on 32-bit systems, and indeed a build failure on armhf on Launchpad was what pointed me to the bug.)

Signed-off-by: Cole Miller cole.miller@canonical.com

codecov[bot] commented 1 year ago

Codecov Report

Merging #519 (225e44b) into master (a7d9115) will increase coverage by 0.01%. The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
+ Coverage   61.37%   61.38%   +0.01%     
==========================================
  Files          34       34              
  Lines        6811     6813       +2     
  Branches     2024     2024              
==========================================
+ Hits         4180     4182       +2     
  Misses       1344     1344              
  Partials     1287     1287              
Impacted Files Coverage Δ
src/server.c 59.19% <75.00%> (+0.08%) :arrow_up: