search

canonical / dqlite

Embeddable, replicated and fault-tolerant SQL engine.
https://dqlite.io
Other
3.77k stars 213 forks source link

Thread pool #550

Closed just-now closed 4 months ago

just-now commented 5 months ago

Draft

codecov[bot] commented 5 months ago

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (dd84623) 61.29% compared to head (81aaf0d) 77.24%. Report is 33 commits behind head on master.

Files Patch % Lines
src/lib/threadpool.c 81.58% 18 Missing and 26 partials :warning:
src/lib/sm.c 40.00% 9 Missing and 9 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #550 +/- ## =========================================== + Coverage 61.29% 77.24% +15.94% =========================================== Files 34 76 +42 Lines 6834 11715 +4881 Branches 2031 2395 +364 =========================================== + Hits 4189 9049 +4860 - Misses 1349 1886 +537 + Partials 1296 780 -516 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cole-miller commented 5 months ago

I'm planning to replace prefix xx elsewhere to something more meaningful. Any ideas? Maybe u (utils) or tu_ (thread utils)?

No strong feelings, maybe apool (for "addressable/affinity pool")?

just-now commented 5 months ago

JFYI: The most stable pool without ordering is 207278083cd44e0e5d87ea15a52f48b3bcd266f6

just-now commented 4 months ago

Closed. Split into a series of commits and posted as a new PR.