canonical / dqlite

Embeddable, replicated and fault-tolerant SQL engine.
https://dqlite.io
Other
3.85k stars 216 forks source link

Fix many cases of arithmetic on void pointers #569

Closed cole-miller closed 7 months ago

cole-miller commented 8 months ago

Currently we use void * as a cursor type when parsing and serializing, and this results in many cases of performing arithmetic on void pointers -- technically UB. Change these types to char * everywhere.

Signed-off-by: Cole Miller cole.miller@canonical.com

codecov[bot] commented 8 months ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (71562ee) 61.29% compared to head (4201b73) 61.29%. Report is 6 commits behind head on master.

Files Patch % Lines
src/lib/serialize.h 79.31% 0 Missing and 6 partials :warning:
src/gateway.c 50.00% 2 Missing and 1 partial :warning:
src/tuple.c 66.66% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #569 +/- ## ======================================= Coverage 61.29% 61.29% ======================================= Files 34 34 Lines 6834 6850 +16 Branches 2031 2039 +8 ======================================= + Hits 4189 4199 +10 + Misses 1349 1345 -4 - Partials 1296 1306 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.