search

canonical / dqlite

Embeddable, replicated and fault-tolerant SQL engine.
https://dqlite.io
Other
3.77k stars 213 forks source link

Thread pool clean #598

Closed just-now closed 4 months ago

codecov[bot] commented 4 months ago

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (6134a79) 81.16% compared to head (3da0521) 81.23%. Report is 2 commits behind head on master.

:exclamation: Current head 3da0521 differs from pull request most recent head 616e1a3. Consider uploading reports for the commit 616e1a3 to get more accurate results

Files Patch % Lines
src/lib/threadpool.c 83.40% 16 Missing and 24 partials :warning:
src/lib/sm.c 53.33% 0 Missing and 14 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #598 +/- ## ========================================== + Coverage 81.16% 81.23% +0.06% ========================================== Files 189 191 +2 Lines 26742 27028 +286 Branches 4859 4919 +60 ========================================== + Hits 21704 21955 +251 + Misses 3455 3445 -10 - Partials 1583 1628 +45 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

just-now commented 4 months ago

src/lib/threadpool.c, line 46, state machine descriptor is just destroyed by clang-format. The following link is just one symptom of clang-format-related issue: https://github.com/clangd/clangd/issues/142

Maybe it's worth trying newer version.

just-now commented 4 months ago

Seems clang-format-15 with Cpp11BracedListStyle: false gives better results.

cole-miller commented 4 months ago

@just-now FYI since #568 merged we now use clang-format 17 in CI