search

canonical / dqlite

Embeddable, replicated and fault-tolerant SQL engine.
https://dqlite.io
Other
3.77k stars 212 forks source link

Bump libuv version requirement to 1.34 #617

Closed cole-miller closed 4 months ago

cole-miller commented 4 months ago

Closes #584

Signed-off-by: Cole Miller cole.miller@canonical.com

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.23%. Comparing base (61fc84c) to head (7540e58). Report is 8 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #617 +/- ## ========================================== + Coverage 81.21% 81.23% +0.01% ========================================== Files 191 191 Lines 27033 27034 +1 Branches 4944 4931 -13 ========================================== + Hits 21956 21962 +6 + Misses 3483 3450 -33 - Partials 1594 1622 +28 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cole-miller commented 4 months ago

I am confused about why codecov doesn't look at the merge commit instead of the tip of the PR branch for comparison purposes. Maybe there's a way to fix that?