search

canonical / dqlite

Embeddable, replicated and fault-tolerant SQL engine.
https://dqlite.io
Other
3.85k stars 216 forks source link

Fix build on alpha and x32 architectures #634

Closed gibmat closed 5 months ago

gibmat commented 5 months ago

Fix compile errors on alpha and x32 architectures, as seen on the Debian builders.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.20%. Comparing base (2b3d6cf) to head (3822a6d). Report is 1 commits behind head on master.

Files Patch % Lines
src/raft/uv_os.c 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #634 +/- ## ========================================== - Coverage 81.21% 81.20% -0.02% ========================================== Files 192 192 Lines 27061 27062 +1 Branches 4943 4975 +32 ========================================== - Hits 21978 21976 -2 - Misses 3445 3488 +43 + Partials 1638 1598 -40 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cole-miller commented 5 months ago

We also need to you sign the CLA before we can merge this -- sorry for the inconvenience.

gibmat commented 5 months ago

We also need to you sign the CLA before we can merge this -- sorry for the inconvenience.

There's nothing mentioning that in the repo (for example, in README, LICENSE, or CONTRIBUTING). :disappointed: I'm not a fan of CLAs, especially for Debian packaging work which is contributed back under a DFSG-compatible license, rendering the CLA unnecessary.

cole-miller commented 5 months ago

There's nothing mentioning that in the repo (for example, in README, LICENSE, or CONTRIBUTING).

This is a very good point! I'll fix it.

I'm not a fan of CLAs, especially for Debian packaging work which is contributed back under a DFSG-compatible license, rendering the CLA unnecessary.

You have my genuine sympathy here, but we can't do anything about the CLA requirement. If you'd prefer not to sign it then with your blessing I can submit and merge an equivalent PR myself. In either case, I appreciate you contributing this fix!

gibmat commented 5 months ago

I'm not a fan of CLAs, especially for Debian packaging work which is contributed back under a DFSG-compatible license, rendering the CLA unnecessary.

You have my genuine sympathy here, but we can't do anything about the CLA requirement. If you'd prefer not to sign it then with your blessing I can submit and merge an equivalent PR myself. In either case, I appreciate you contributing this fix!

Sure, I'm fine with you making an equivalent PR and then closing this one. That's much preferred versus carrying an additional patch for Debian.

cole-miller commented 5 months ago

Closing as superseded by #640