search

canonical / dqlite

Embeddable, replicated and fault-tolerant SQL engine.
https://dqlite.io
Other
3.77k stars 212 forks source link

Prepare to merge dqlite-next into master #642

Closed cole-miller closed 2 months ago

cole-miller commented 2 months ago

Let's do all our work on one branch, with experimental stuff (like thread pool and vfs2 integration) guarded behind #ifdef DQLITE_NEXT. This will avoid a big merge headache down the line.

Signed-off-by: Cole Miller cole.miller@canonical.com

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.56%. Comparing base (4d74efa) to head (ec33e4f). Report is 3 commits behind head on dqlite-next.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dqlite-next #642 +/- ## ============================================ Coverage 80.56% 80.56% ============================================ Files 196 196 Lines 28300 28304 +4 Branches 5297 5300 +3 ============================================ + Hits 22799 22804 +5 + Misses 3808 3767 -41 - Partials 1693 1733 +40 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cole-miller commented 2 months ago

@just-now I think this is good to go, would appreciate you confirming that I didn't miss anything important when adding ifdefs.

cole-miller commented 2 months ago

Pushed https://github.com/canonical/dqlite/pull/642/commits/24a4879de5c3dbddc860818232bc77d1e4514c9f to codify that dqlite-next relies (will rely) on using the bundled raft sources and headers, since we will be making incompatible changes like #639.