canonical / dqlite

Embeddable, replicated and fault-tolerant SQL engine.
https://dqlite.io
Other
3.85k stars 216 forks source link

Use system raft headers when not building raft #645

Closed cole-miller closed 5 months ago

cole-miller commented 5 months ago

This is a bug that I introduced during the raft import: the bundled raft.h (which concatenates raft's raft.h, raft/uv.h, and raft/fixture.h) is included everywhere even if we don't use the bundled raft sources. Fix this so we always use the headers that correspond to the raft code that will be called at runtime. This is necessary to support breaking changes to raft data structures and functions under DQLITE_NEXT.

Signed-off-by: Cole Miller cole.miller@canonical.com

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.31%. Comparing base (e814a1c) to head (85d23ed). Report is 26 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #645 +/- ## ========================================== - Coverage 81.23% 80.31% -0.92% ========================================== Files 192 192 Lines 27061 27058 -3 Branches 4980 4950 -30 ========================================== - Hits 21982 21732 -250 - Misses 3436 3512 +76 - Partials 1643 1814 +171 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.