search

canonical / dqlite

Embeddable, replicated and fault-tolerant SQL engine.
https://dqlite.io
Other
3.77k stars 212 forks source link

github: Restore raft testing on other filesystems #647

Open cole-miller opened 2 months ago

cole-miller commented 2 months ago

I neglected to set this up when doing the raft import, and was reminded because this additional testing should pick up the original issue that this patch---since reverted by #641---addressed.

Signed-off-by: Cole Miller cole.miller@canonical.com

cole-miller commented 2 months ago

Indeed, failures with xfs and btrfs are back:

2024-04-26T10:07:16.7647685Z UvWriterClose/aio                                           
2024-04-26T10:07:16.7648335Z   dir-fs=btrfs                                              [ ERROR ]
2024-04-26T10:07:16.7649228Z Error: test/raft/unit/test_uv_writer.c:49: assertion failed: status == result->status (0 == 13)
2024-04-26T10:07:16.7649925Z Error: child killed by signal 6 (Aborted)
2024-04-26T10:07:16.7650721Z   dir-fs=ext4                                               [ OK    ] [ 0.03586379 / 0.00012271 CPU ]
2024-04-26T10:07:16.7651343Z   dir-fs=xfs                                                [ ERROR ]
2024-04-26T10:07:16.7652115Z Error: test/raft/unit/test_uv_writer.c:49: assertion failed: status == result->status (0 == 13)
letFunny commented 2 months ago

Does this mean that the CI is no longer going to be green? If that is the case, do we plan to fix this tests?

cole-miller commented 2 months ago

I don't plan to merge this with the tests failing, we need to fix them one way or another. Currently trying to figure out whether there's a proper fix that doesn't cause the same issue as canonical/raft#485.