Closed cole-miller closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.43%. Comparing base (
14bc162
) to head (0710242
). Report is 164 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@marco6 pointed out this
return
that should be acontinue
, which causes us to skip processing some KAIO write results if we get several of them in a batch and one of them has status code EAGAIN.In practice, when running our test suite, it seems that io_getevents never returns more than one event in this context, which together with the dependence on getting EAGAIN explains why we never noticed this while developing dqlite or raft. But in production we could certainly encounter
n_events > 1
.Signed-off-by: Cole Miller cole.miller@canonical.com