search

canonical / edgex-checkbox-provider

Checkbox tests for EdgeX snaps
Apache License 2.0
0 stars 3 forks source link

Add readme #9

Closed MonicaisHer closed 2 years ago

MonicaisHer commented 2 years ago

Signed-off-by: Mengyi Wangmengyi.wang@canonical.com

farshidtz commented 2 years ago

Thanks a lot, the readme is very good. I added some minor inline comments.

I'm yet to test the commands and provide feedback on those.

farshidtz commented 2 years ago

I noticed that the README is missing instructions for running the tests in the snap. This would be very useful to run tests in isolation. It should actually be the preferred way to run tests.

MonicaisHer commented 2 years ago

@farshidtz Thanks a lot for your review. I have add a Run tests using checkbox-edgexfoundry snap in isolation (recommend) section.

siggiskulason commented 2 years ago

Excellent. Can we then delete the old draft document at https://docs.google.com/document/d/1KK3vfxANapKqkzNlP_ai1yczlvp3gfqQnvhRXv-v12Y/edit#heading=h.qjjnvsuim13r ? Is there anything in there that's not covered here?

farshidtz commented 2 years ago

Thanks. I'm going to merge and defer minor polishing to another PR.

Thanks a lot @MonicaisHer

MonicaisHer commented 2 years ago

@siggiskulason I think this README covered your HOWTO documentation. Thank you!

farshidtz commented 2 years ago

I forgot to squash before merging and that created a mess. I force pushed a squashed version.