search

canonical / envoy-operator

Envoy Operator
Apache License 2.0
2 stars 1 forks source link

Sidecar rewrite: envoy #71

Closed misohu closed 5 months ago

misohu commented 7 months ago

Context

We rewrite all of our charms using the sidecar with base charm pattern instead of the old podspec.

What needs to get done

Rewrite the charm using sidecar with base charm pattern.

Definition of Done

Charm is rewritten with sidecar with base charm pattern. All of the tests are rewritten and passing.

syncronize-issues-to-jira[bot] commented 7 months ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5257.

This message was autogenerated

DnPlas commented 7 months ago

When we work on this task, we have to have in mind that we will need to migrate the k8s-service relation interface from its SDI implementation to the newer one handled by a library. See https://github.com/canonical/mlops-libs/issues/2 for more information about the library and what it entails.

Context

Based on the proposal in https://github.com/canonical/mlops-libs/issues/2 and the changes that are going to be introduced in https://github.com/canonical/mlmd-operator/issues/71 we'll need to update the k8s-service relation interface handling this charm.

What needs to get done

Replace the SDI component that handles this relation interface with the library that is going to be created in https://github.com/canonical/mlops-libs/issues/2

Definition of Done

  1. The SDI implementation is replaced with the library proposed in https://github.com/canonical/mlops-libs/issues/2
  2. There is a working upgrade path from a previous version of this charm
ca-scribner commented 6 months ago

This'll take a bit more effort than usual because of https://github.com/canonical/charmed-kubeflow-chisme/issues/89. We need to solve https://github.com/canonical/charmed-kubeflow-chisme/issues/89 before we can write Envoy using the CharmReconciler because we need to push a config file to the container that requires inputs from other components.

I have a working solution to this that wont be a huge effort, but it still adds maybe an extra half a day or so to the rewrite