search

canonical / firmware-updater

An experimental firmware updater UI based on fwupd
GNU General Public License v3.0
115 stars 17 forks source link

Multiple messages get overlayed #193

Open merlijn-sebrechts opened 1 year ago

merlijn-sebrechts commented 1 year ago

When you update, for example, the package level of a Dell dock, you get multiple messages asking you to unplug the device in order to continue the update. There are a few issues with these

  1. The popups get stacked, including the "shadow" effect of the firmware updater app itself. Each layer of popup thus makes the underlying window darker
  2. You get multiple of the exact same popups. I initially thought the app crashed because the button did not appear to do anything until I realized I was dismissing multiple layers of popups.

I think 1. is simply a UI or toolkit bug. 2. will probably need some UX work to figure out what the best way is to notify users of multiple (sub-)devices requiring the same action.

chochien commented 3 months ago

It was because of the Dell dock firmware package included 5 kinds of firmware. Here is use WD22TB to test. when one firmware update successful, the unplug message will pop up once. Totally pop up 5 times.

If the pop up mechanism can chagned to finsh whole package upgrade then pop up. it will make user unplug the dock at the right moment.

chochien commented 1 month ago

I capture a video [1] when the issue failure for your reference.

[1] https://drive.google.com/file/d/1Pnq-RwObLivpaIMvjwZXjeqR4ri7awuS/view?usp=drive_link