search

canonical / firmware-updater

An experimental firmware updater UI based on fwupd
GNU General Public License v3.0
107 stars 15 forks source link

Generate an AlertDialog screen when A/C must be applied for some updates to proceed - this is issue #215. #256

Open Glen-Campbell-Bose opened 5 months ago

Glen-Campbell-Bose commented 5 months ago

Add an alert dialog that looks like this:

image

github-actions[bot] commented 5 months ago

Everyone contributing to this PR have now signed the CLA. Thanks!

Glen-Campbell-Bose commented 5 months ago

Pardon the newbie stuff here - trying to get my ducks in a row with regard to submissions ...

d-loose commented 5 months ago

Thanks for your contribution! Unfortunately the firmware updater doesn't get the attention it deserves at the moment, as our team is working on other projects with higher priority for 24.04, so respond times are likely to remain slow - my apologies!

I noticed that we still don't have a proper contribution guide for this repo - @BLKKKBVSIK could you create one similar to the one we have for app-center if you got some spare time in the next weeks?

Concerning your PR - thanks, I think this is an improvement over the subtle and confusing banner on the top of the window. I hope @anasereijo can give you some feedback on the UI at some point. Besides that, you'd need to take a look at the failing tests. With a UI change like this, some of them might need to be adjusted. Please let us know if you need any help, although we can't guarantee very quick replies at the moment.