canonical / firmware-updater

An experimental firmware updater UI based on fwupd
GNU General Public License v3.0
107 stars 15 forks source link

App name in desktop file not translatable #292

Open AsciiWolf opened 1 month ago

AsciiWolf commented 1 month ago

It looks like that the "Firmware Updater" app name is always in English in GNOME Shell Overview although it is fully translated.

overview

Same issue with its comment (that is not translatable at all).

AsciiWolf commented 1 month ago

Possible solution (although not an ideal one) could be adding the translated Name and Comment sections manually to the desktop file just like app-center did.

AsciiWolf commented 1 month ago

Here is an example of how it would look for the Czech language:

diff --git a/packages/firmware_updater/assets/firmware-updater.desktop b/packages/firmware_updater/assets/firmware-updater.desktop
index 7a8d875..16f1c1c 100644
--- a/packages/firmware_updater/assets/firmware-updater.desktop
+++ b/packages/firmware_updater/assets/firmware-updater.desktop
@@ -2,7 +2,9 @@
 Type=Application
 Version=1.0
 Name=Firmware Updater
+Name[cs]=Aktualizátor firmwaru
 Comment=Manage firmware on your device
+Comment[cs]=Spravujte firmware na vašem zařízení
 Keywords=firmware;
 #use sh because pkexec is broken under xfce/lxce http://pad.lv/1193526
 Exec=firmware-updater

Feel free to apply these changes or if you wish, I can make a Pull request. ;-)

AsciiWolf commented 3 weeks ago

/cc @d-loose