search

canonical / firmware-updater

An experimental firmware updater UI based on fwupd
GNU General Public License v3.0
115 stars 17 forks source link

Update Available pill hides the device name #69

Open Feichtmeier opened 2 years ago

Feichtmeier commented 2 years ago

grafik

An idea would be to exchange the subtile with the pill if upgradeAvailable :shrug:

grafik

jpnurmi commented 2 years ago

would it make sense to replace the device icon with a green "update" icon?

Feichtmeier commented 2 years ago

That would be cool only needs a change in yaruwidgets so let the normal master detail page make use of the yarupageitem itemWidget property (which is currently only being used in the compact layout) But I think to remember that elio almost always prefers text over icons :P for usability accessibility reasons =)

elioqoshi commented 2 years ago

would it make sense to replace the device icon with a green "update" icon?

I'd not say so. Iconography should not replace label

An idea would be to exchange the subtitle with the pill if upgradeAvailable 🤷

Can't the pill be added underneath the subtitle and expand the row height? That would be cleaner.

Also I think if the label is simply "Update" that would suffice.

elioqoshi commented 2 years ago

Also we might want to use yellow for the pills as the Update is something which requires attention and is technically not in an ideal state to be signaled by green.

Also my Twitter followers agree with me :p

https://twitter.com/elioqoshi/status/1577355913211543554

Edit: Okay my Twitter friends are more divisive than I thought. An alternative could be ha a neutral color for the chip.

d-loose commented 2 years ago

Right now it's set to the theme's accent color (so not necessarily green). Should it be a fixed color like below instead? I found it easier to move the pill to the right and make the text wrap around it: image image